You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rebuild every theme jquery-ui.css file on the 1.14.2 shared structure while preserving each theme's existing ThemeRoller colors and shadow settings.
Replace deprecated local buttonset() calls with controlgroup() now that jQuery UI 1.14.2 no longer enables the backcompat path by default.
Add Playwright smoke coverage for the jQuery UI controlgroup() path.
Notes
jQuery core stays at 3.7.1 in this PR. jQuery 4.0.0 is current, but it is a major release with breaking removals and should be handled as a separate migration with broader plugin testing.
The jQuery UI assets were pulled from the official 1.14.2 distribution.
Testing
node --check include/js/jquery-ui.js
node --check include/layout.js
node --check include/themes/dark/main.js
node --check include/themes/modern/main.js
node --check tests/e2e/jquery-smoke.spec.js
git diff --check
rg checks for stale jQuery UI versions, deprecated buttonset() calls, and old IE-only CSS compatibility lines
Not run locally:
npx --no-install playwright test tests/e2e/jquery-smoke.spec.js could not run because Playwright is not installed in this worktree; npx --no-install attempted npm registry access and failed under restricted network.
Heads up: this drops the explicit $.uiBackCompat = true; assignment at the top of jquery-ui.js. The bundled jQuery UI still has nine if ($.uiBackCompat === true) checks (slider, sortable, draggable, etc.) that will now evaluate to undefined rather than true, silently switching those widgets to the post-1.14 path. If we want the new defaults that's fine, but it deserves a note in the PR body and a smoke pass on the affected widgets in graph-tree / device-list / dashboard.
@somethingwithproof is this still WIP? It appears from your comment that this might be a breaking change for things like tree view if say for example draggable is gone.
Yes, still WIP. You're right to flag it: dropping $.uiBackCompat = true; breaks the nine uiBackCompat === true paths (draggable, sortable, slider) that tree view relies on. I'll restore that assignment before taking this out of draft.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jquery-ui.cssfile on the 1.14.2 shared structure while preserving each theme's existing ThemeRoller colors and shadow settings.buttonset()calls withcontrolgroup()now that jQuery UI 1.14.2 no longer enables the backcompat path by default.controlgroup()path.Notes
Testing
node --check include/js/jquery-ui.jsnode --check include/layout.jsnode --check include/themes/dark/main.jsnode --check include/themes/modern/main.jsnode --check tests/e2e/jquery-smoke.spec.jsgit diff --checkrgchecks for stale jQuery UI versions, deprecatedbuttonset()calls, and old IE-only CSS compatibility linesNot run locally:
npx --no-install playwright test tests/e2e/jquery-smoke.spec.jscould not run because Playwright is not installed in this worktree;npx --no-installattempted npm registry access and failed under restricted network.